🚀 Space Reviewers 👾 Episode 5 - PR review deep dive Ticket 36352

In this episode Lilian does a deep dive into her PR review process for Ticket 36352.

Ticket problem: The ticket is about not being able to reference an annotated field when having multiple chains of values(). It is currently raising a FieldError, and the error suggests using another annotate() to promote the field.

Ticket: https://code.djangoproject.com/ticket/36352
PR: https://github.com/django/django/pull/19478
Review notes: https://github.com/djangonaut-space/space-reviewers/blob/main/Episode-5/pr-review-deep-dive-ticket-36352.md and https://github.com/ontowhee/django-tickets/blob/main/ticket-36352.md

0:00 - Intro, links to notes and contributing documentation
1:13 - Understanding ticket problem and potential solution
7:00 - Walking through the bisected commit / ticket 34437
16:05 - Looking for context on annotation masking
20:10 - Debugging bisected commit
34:20 - Walking through PR 19487 file changes
36:09 - Fetching and switching to PR 19487
46:14 - Test is written for the M2M field authors
46:27 - Annotation field names do not need to obscure existing field names for the FieldError to occur
49:10 - Changing annotation field name to demonstrate FieldError
50:35 - Switching field names to demonstrate the error still occurs on the second chained values().
52:35 - Reviewing notes and trying to wrap up
59:35 - Going through "Contributing Checklist"
1:04:09 - Composing review comments and questions
1:04:28 - Revisiting comment about the guard on FieldError
1:05:52 - Debugging guard on FieldError
1:09:55 - Writing review
1:11:58 - Posting review